move toward option print/parse parity #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haesbaert
requested changes
Mar 31, 2017
lib/dhcp_wire.ml
Outdated
| | 86 -> take (Nds_tree_name (get_string ())) | ||
| | 87 -> take (Nds_context (get_string ())) | ||
| | 88 -> take (Bcmcs_controller_domain_name_list (get_string ())) | ||
| | 89 -> take (Bcmcs_controller_ipv4_addrs (get_ip_list ~min_len:1 ())) |
There was a problem hiding this comment.
min_len in this function is not List.length, it is the minimum size of the object in bytes, so the correct should be the default min_len:4, which is one ip.
lib/dhcp_wire.ml
Outdated
| | 89 -> take (Bcmcs_controller_ipv4_addrs (get_ip_list ~min_len:1 ())) | ||
| | 90 -> take (Authentication (get_string ())) | ||
| | 91 -> take (Client_last_transaction_time (get_32 ())) | ||
| | 92 -> take (Associated_ips (get_ip_list ~min_len:1 ())) |
There was a problem hiding this comment.
Thanks! min_len is correctly specified in the default for get_ip_list, so I'll just remove it -- not sure what I was thinking here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch,
buf_of_pktwill emit options thatpkt_of_bufdiscards. This patch is an attempt to use the existing parser functions to implement the options whichbuf_of_pktwill output at user request.