Refactor configuration processing #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
force-pushed
the
refactor-config-handling
branch
from
1b65546 to
be23a38
Compare
craigfe
force-pushed
the
refactor-config-handling
branch
from
be23a38 to
876ecb2
Compare
Co-authored-by: ngoguey <ngoguey@student.42.fr>
This is currently failing to update `brew` on Mac OS runners: ``` +echo 'brew update is still running...' brew update is still running... +sleep 60 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraction of some refactoring from #294. Defines config keys and their defaults in one place, and avoids shunting individual flags around in the Cli definition.