Skip to content

Refactor norm_linear into struct functor #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: mpk
Choose a base branch
from
Open

Refactor norm_linear into struct functor #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4c650b
refactor norm_linear into struct functor
NorthmanPKU Jul 24, 2025
5e853ed
merge mpk
NorthmanPKU Jul 25, 2025
84b02df
add static
NorthmanPKU Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/mirage/persistent_kernel/runtime_header.h
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is because __CUDA_ARCH__ wasn't passed into this header file.

Copy link
Collaborator Author

@NorthmanPKU NorthmanPKU Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like __CUDA_ARCH__ can only be used in the implementation of GPU functions

Copy link
Collaborator Author

@NorthmanPKU NorthmanPKU Jul 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use cudaGetDeviceProperties in host side to get & set the maximum smem size. And use CUDA_ARCH in device side to do so.

Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ constexpr int MAX_SHARE_MEMORY_SIZE = 224 * 1024;
constexpr int MAX_SHARE_MEMORY_SIZE = 96 * 1024;
#elif defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 800
constexpr int MAX_SHARE_MEMORY_SIZE = 160 * 1024;
#else
constexpr int MAX_SHARE_MEMORY_SIZE = 96 * 1024;
#else // TODO: This always fall into else case
constexpr int MAX_SHARE_MEMORY_SIZE = 160 * 1024;
#endif

typedef unsigned long long int TaskId;
Expand Down
Loading