feat: Add sine and cosine operations to Mirage framework #380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhihao
added
the
CUDA Transpiler
|
Looks like I forgot something which was not caught by local build Will fix it and write proper tests |
wmdi
reviewed
Jul 13, 2025
| uint32_t q_residual = input % FP_Q; | ||
| uint32_t p_residual = input % FP_P; | ||
| // Simulate sin by using some transformation of the input | ||
| q_residual = (q_residual * 7) % FP_Q; // Simple transformation |
There was a problem hiding this comment.
I think this simulation is too simple and can be easily confused with scalar multiplication, which may cause false positive. Could you change to a better one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Sin & Cos activation
Related Issues:
Linked Issues:
Issues closed by this PR: