Fix N shape bugs #157
Merged
Fix N shape bugs #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nw13slx
reviewed
Feb 22, 2022
nequip/data/dataset.py
Outdated
| N = N.unsqueeze(-1) | ||
| assert N.ndim == 2 | ||
| assert N.shape == (len(arr), 1) | ||
| assert arr.ndim == 2 |
There was a problem hiding this comment.
should we make N the same shape as arr from the 2nd axis?
There was a problem hiding this comment.
what do you mean?
nw13slx
reviewed
Feb 22, 2022
nequip/data/dataset.py
Outdated
Comment on lines
544
to
546
| data_dim = arr.shape[1] | ||
| arr = arr / N | ||
| assert arr.shape == (len(N), data_dim) |
There was a problem hiding this comment.
Suggested change
| data_dim = arr.shape[1] | |
| arr = arr / N | |
| assert arr.shape == (len(N), data_dim) | |
| data_dim = arr.shape[1:] | |
| arr = arr / N | |
| assert arr.shape == (len(N), data_dim) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.