Skip to content

Comments

Fix AWS observability calls#483

Merged
KaQuMiQ merged 1 commit intomainfrom
feature/cloudwatch_fix
Jan 21, 2026
Merged

Fix AWS observability calls#483
KaQuMiQ merged 1 commit intomainfrom
feature/cloudwatch_fix

Conversation

@KaQuMiQ
Copy link
Collaborator

@KaQuMiQ KaQuMiQ commented Jan 21, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Walkthrough

Renames internal CloudWatch background callback calls in src/draive/aws/observability.py: log_puttingput_log, event_puttingput_event, metric_puttingput_metric. Tests (tests/test_aws_state_observability.py) are updated to initialize AWSCloudwatch via an async with ctx.scope(AWSCloudwatch()): context and move scope start/end, attribute recording, metric/event emissions and their awaits into that context. Payload shapes, control flow, and error handling are unchanged. Total lines changed are small across the module and tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Add CloudWatch Observability #482: Renaming of background callbacks to put_* interfaces is directly related to earlier CloudWatch observability additions that introduced the AWSCloudwatch state and its put_log/put_event/put_metric methods.
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided by the author. While the title is descriptive, a description would be helpful for understanding the rationale and scope of the fixes. Add a pull request description explaining what specific issues were fixed and why the observability calls needed correction.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix AWS observability calls' directly relates to the changeset, which corrects AWSCloudwatch method names and improves observability instrumentation control flow.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KaQuMiQ KaQuMiQ force-pushed the feature/cloudwatch_fix branch from ada9190 to b41e06b Compare January 21, 2026 12:27
@KaQuMiQ KaQuMiQ merged commit bb23327 into main Jan 21, 2026
2 of 3 checks passed
@KaQuMiQ KaQuMiQ deleted the feature/cloudwatch_fix branch January 21, 2026 12:29
@coderabbitai coderabbitai bot mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant