Cleanup

[KaQuMiQ]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates version metadata and refactors tool specifications to typed objects, changing availability callbacks to accept ModelToolSpecification. It standardizes discriminant fields from kind to type across public models, adds default META_EMPTY, and renames several streaming/session methods. Mistral streaming completions now validate tool call indices and handle 0 as valid. Multimodal content parsing is rewritten with a token-based engine, changing tag extraction/replacement behaviors and signatures. Generative models gain multi-modal selection filtering for both streaming and non-streaming paths. Instructions modules receive enhanced docstrings and stricter file-storage error handling. Tests are updated and expanded to cover new multimodal and toolbox behaviors.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

• Broad, heterogeneous changes across models, tools, multimodal parsing, generators, and tests.
• Public API shifts (kind→type, defaults, signatures), typed tool spec adoption, and streaming semantics.
• Dense logic in multimodal token parser and toolbox/tool availability wiring.
• Multiple pathways (streaming/non-streaming) and extensive test updates require careful cross-checking.

Possibly related PRs

• Add RealtimeConversation #330 — Also modifies src/draive/multimodal/content.py, touching tag parsing and content assembly logic.
• Switch to non-strict OpenAI tools #412 — Refactors tool specification representation to typed objects and updates call sites, aligning with this PR’s tool spec changes.
• Refine toolbox and extend tool handling modes #374 — Toolbox/tooling refactors affecting availability interfaces overlap with this PR’s availability signature changes.

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	No pull request description was provided in the PR; because the description does not describe any part of the changeset it is effectively missing and therefore fails this check. A minimal descriptive summary is required so reviewers can understand scope, intent, and any public API or behavioral changes from the diff.	Please add a short PR description summarizing the goal and notable changes (for example: type discriminator renames from kind→type, ModelToolSpecification and FunctionTool refactor, multimodal content parser rewrite, added multimodal tests, and the package version bump to 0.84.7) and call out any public API or migration notes so reviewers know what to focus on.
Docstring Coverage	⚠️ Warning	Docstring coverage is 38.38% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check	❓ Inconclusive	The provided title "Cleanup" is too generic to convey the primary change set; the diff shows many substantive changes (tool/specification typing and availability signature updates, discriminant renames from kind→type, a rewrite of the multimodal tag parser, several new/updated tests, and a version bump), so a reviewer scanning history cannot determine the main intent from "Cleanup" alone. Because the title does not summarize the main change or indicate whether the PR is primarily a refactor, feature, or bugfix, the check is inconclusive.	Please replace "Cleanup" with a concise, specific single-sentence title that highlights the principal change (for example: "Refactor tool specifications and availability; rewrite multimodal tag parser; add multimodal tests and bump to 0.84.7"), or state which of the large changes is primary so reviewers can quickly understand the PR's intent.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a43ccd4 and 8183bfb.

📒 Files selected for processing (21)

• pyproject.toml (1 hunks)
• src/draive/mcp/client.py (2 hunks)
• src/draive/mistral/completions.py (1 hunks)
• src/draive/models/__init__.py (1 hunks)
• src/draive/models/generative.py (6 hunks)
• src/draive/models/instructions/repository.py (8 hunks)
• src/draive/models/instructions/template.py (2 hunks)
• src/draive/models/instructions/types.py (9 hunks)
• src/draive/models/tools/__init__.py (2 hunks)
• src/draive/models/tools/function.py (12 hunks)
• src/draive/models/tools/provider.py (1 hunks)
• src/draive/models/tools/toolbox.py (9 hunks)
• src/draive/models/tools/types.py (3 hunks)
• src/draive/models/types.py (19 hunks)
• src/draive/multimodal/artifact.py (1 hunks)
• src/draive/multimodal/content.py (23 hunks)
• src/draive/openai/responses.py (6 hunks)
• tests/test_model.py (7 hunks)
• tests/test_tags_extraction.py (4 hunks)
• tests/test_tags_replacement.py (5 hunks)
• tests/test_toolbox.py (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}