Cleanup and formatting

[KaQuMiQ]

No description provided.

[coderabbitai]

Walkthrough

This change updates the project version in pyproject.toml from 0.71.0 to 0.71.1. In src/draive/gemini/lmm_generation.py, it introduces more explicit keyword arguments, improved type annotations, and expanded formatting for readability across multiple methods. Exception handling for rate limiting is enhanced with randomized retry delays. The code now consistently uses keyword arguments and explicit typing in method signatures and internal logic. The fallback stub for ResourceExhausted was removed in favor of direct import with a pyright ignore comment. In src/draive/tools/function.py, the default lambda parameter is renamed for clarity, and the error logging message is made more descriptive. In src/draive/instructions/state.py, the _empty asynchronous function signature is simplified by removing the unused name parameter.

Possibly related PRs

• 🐛 Add meta arg to default availability lambda #342: Modifies the default availability check lambda and error logging message in the FunctionTool class, directly affecting the same code as in this PR.
• Add Gemini streaming #340: Extends and refines the Gemini LMM generation implementation, introducing detailed exception handling and improved typing in the same components updated by this PR.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 70790e0 and e8ac704.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• pyproject.toml (1 hunks)
• src/draive/gemini/lmm_generation.py (11 hunks)
• src/draive/instructions/state.py (0 hunks)
• src/draive/tools/function.py (2 hunks)

💤 Files with no reviewable changes (1)

• src/draive/instructions/state.py

🧰 Additional context used

🪛 Pylint (3.3.7)

src/draive/gemini/lmm_generation.py

[convention] 1-1: Missing module docstring

(C0114)

---

[error] 6-6: Unable to import 'google.api_core.exceptions'

(E0401)

---

[error] 6-6: No name 'api_core' in module 'google'

(E0611)

---

[refactor] 421-425: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

(R1705)

🔇 Additional comments (8)

pyproject.toml (1)

8-8: Version bump looks appropriate for cleanup changes.

The patch version increment from 0.71.0 to 0.71.1 correctly reflects the nature of this PR's cleanup and formatting improvements.

src/draive/tools/function.py (2)

109-109: Good use of underscore convention for unused parameter.

The change from meta to _ clearly indicates the parameter is intentionally unused, following Python conventions.

---

153-153: Improved error message provides better context.

The enhanced message now includes the tool name and clearly states the consequence of the availability check failure, which will aid in debugging and monitoring.

src/draive/gemini/lmm_generation.py (5)

1-1: Import of random module is appropriate for retry logic.

The addition of the random module import supports the new randomized retry delay feature for rate limiting, which helps avoid thundering herd problems.

---

6-6: Direct import with pyright ignore is cleaner.

Removing the fallback stub in favor of a direct import with pyright: ignore comment is a cleaner approach for handling potentially missing imports.

---

360-365: Excellent use of keyword-only arguments for clarity.

The consistent adoption of keyword-only arguments across multiple methods improves code readability and prevents parameter ordering mistakes. This is particularly valuable for methods like _record_usage_metrics and _validate_finish_reason that have multiple parameters.

Also applies to: 392-397, 417-420, 447-448, 458-459

---

315-346: Well-structured streaming improvements enhance observability.

The changes improve streaming processing with:

• Clear content wrapping using MultimodalContent.of()
• Individual tool request recording for better observability
• Explicit EOD chunk with proper return statement

These enhancements will significantly aid in debugging and monitoring streaming responses.

---

559-559: Good simplification of system instruction handling.

Removing the conditional fallback and directly passing the instruction value simplifies the code without losing functionality.

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

src/draive/gemini/lmm_generation.py (1)

208-215: Good implementation of retry jitter.

The randomized retry delay (0.3-3.0s) helps prevent thundering herd problems when rate limits are hit. Both streaming and non-streaming methods now use the same approach, which addresses the consistency concern.

Also applies to: 267-273

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8ac704 and 904d576.

⛔ Files ignored due to path filters (1)

• uv.lock is excluded by !**/*.lock

📒 Files selected for processing (4)

• pyproject.toml (1 hunks)
• src/draive/gemini/lmm_generation.py (11 hunks)
• src/draive/instructions/state.py (0 hunks)
• src/draive/tools/function.py (2 hunks)

💤 Files with no reviewable changes (1)

• src/draive/instructions/state.py

🧰 Additional context used

🪛 Pylint (3.3.7)

src/draive/gemini/lmm_generation.py

[convention] 1-1: Missing module docstring

(C0114)

---

[error] 6-6: Unable to import 'google.api_core.exceptions'

(E0401)

---

[error] 6-6: No name 'api_core' in module 'google'

(E0611)

---

[refactor] 423-427: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it

(R1705)

🔇 Additional comments (7)

pyproject.toml (1)

8-8: Version bump looks appropriate.

The patch version increment from 0.71.0 to 0.71.1 correctly reflects the nature of changes in this PR (cleanup, formatting, and minor improvements).

src/draive/tools/function.py (2)

109-109: Good use of Python convention for unused parameter.

Using _ instead of meta clearly indicates that the parameter is intentionally unused in the default availability check.

---

153-153: Improved error message with better context.

The enhanced error message now includes the tool name and clearly states the consequence, making debugging easier.

src/draive/gemini/lmm_generation.py (4)

1-1: Import changes look good.

The addition of random for retry jitter and direct import of ResourceExhausted with pyright ignore improves the code. The GenerateContentResponseUsageMetadata type import enhances type safety.

Also applies to: 6-6, 16-16

---

362-392: Well-structured usage metrics recording.

The refactored _record_usage_metrics method with explicit None check and keyword-only arguments improves code clarity and safety.

---

348-348: Cleaner flow control with explicit return.

Using return instead of break makes the stream termination more explicit and easier to understand.

---

561-561: Simplified system instruction handling.

Removing the conditional fallback and always passing the instruction value directly simplifies the code and makes the behavior more predictable.