Add path parameter to get_quota interface#25
Open
Vigilans wants to merge 1 commit intomiquels:masterfrom
Open
Conversation
This was referenced Oct 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
pathparameter toDavFileSystemtrait'sget_quotainterface.There are many cases when we use a folder like
/mediato export as webdav file root, but subfolders in/mediaare mounted with other filesystems:Currently,
get_quotaonly collects quota information of root folder (the/media), even the client is querying quota information of path/media/dirAor/media/dirB.When using clients like
RaiDrivein Windows, it will report disk usage just like normal physical disks, and we expect it to show the correct disk usage of drive/media/dirAor/media/dirB(maybe some TBs large), but not the/mediafrom rootfs `(maybe just tens of GBs).This PR adds a
pathparameter toget_quotainterface, so its implementations could make use of the path information to return the correct quota information of corresponding disk.This PR depends on #11 to return quota information for all directory path, instead of return only for root (
/) path, and is implemented by miquels/webdav-server-rs#19.