improve exception message, add test (resilience4j#2222)

miqdigital · Oct 21, 2024 · ce6cf63 · ce6cf63
1 parent a2a0616
commit ce6cf63
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/...cuitbreaker/src/main/java/io/github/resilience4j/circuitbreaker/CircuitBreakerConfig.java b/...cuitbreaker/src/main/java/io/github/resilience4j/circuitbreaker/CircuitBreakerConfig.java
@@ -363,7 +363,7 @@ public Builder() {
         public Builder failureRateThreshold(float failureRateThreshold) {
             if (failureRateThreshold <= 0 || failureRateThreshold > 100) {
                 throw new IllegalArgumentException(
-                    "failureRateThreshold must be between 1 and 100");
+                    "failureRateThreshold must be greater than 0 and lower than 100, but was " + failureRateThreshold);
             }
             this.failureRateThreshold = failureRateThreshold;
             return this;
@@ -388,7 +388,7 @@ public Builder failureRateThreshold(float failureRateThreshold) {
         public Builder slowCallRateThreshold(float slowCallRateThreshold) {
             if (slowCallRateThreshold <= 0 || slowCallRateThreshold > 100) {
                 throw new IllegalArgumentException(
-                    "slowCallRateThreshold must be between 1 and 100");
+                    "slowCallRateThreshold must be greater than 0 and not greater than 100, but was " + slowCallRateThreshold);
             }
             this.slowCallRateThreshold = slowCallRateThreshold;
             return this;

diff --git a/...breaker/src/test/java/io/github/resilience4j/circuitbreaker/CircuitBreakerConfigTest.java b/...breaker/src/test/java/io/github/resilience4j/circuitbreaker/CircuitBreakerConfigTest.java
@@ -131,6 +131,13 @@ public void shouldSetFailureRateThreshold() {
         then(circuitBreakerConfig.getFailureRateThreshold()).isEqualTo(25);
     }
 
+
+    @Test
+    public void shouldSetFailureRateThresholdAsAFloatGreaterThanZero() {
+        CircuitBreakerConfig circuitBreakerConfig = custom().failureRateThreshold(0.5f).build();
+        then(circuitBreakerConfig.getFailureRateThreshold()).isEqualTo(0.5f);
+    }
+
     @Test
     public void shouldSetWaitDurationInHalfOpenState() {
         CircuitBreakerConfig circuitBreakerConfig = custom().maxWaitDurationInHalfOpenState(Duration.ofMillis(1000)).build();
@@ -143,6 +150,12 @@ public void shouldSetSlowCallRateThreshold() {
         then(circuitBreakerConfig.getSlowCallRateThreshold()).isEqualTo(25);
     }
 
+    @Test
+    public void shouldSetSlowCallRateThresholdAsFloatGreaterThanZero() {
+        CircuitBreakerConfig circuitBreakerConfig = custom().slowCallRateThreshold(0.5f).build();
+        then(circuitBreakerConfig.getSlowCallRateThreshold()).isEqualTo(0.5f);
+    }
+
     @Test
     public void shouldSetSlowCallDurationThreshold() {
         CircuitBreakerConfig circuitBreakerConfig = custom()