feat: support laravel 12 #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricklambrechts
force-pushed
the
support-laravel
branch
from
5e46881 to
be34ee5
Compare
ricklambrechts
force-pushed
the
support-laravel
branch
2 times, most recently
from
ec2ddd6 to
9ffa1a3
Compare
ricklambrechts
force-pushed
the
support-laravel
branch
from
9ffa1a3 to
0234a0d
Compare
randh1r
approved these changes
May 12, 2025
It is indeed ignored/ has no effect in previous PHP versions. If wanted we could add this polyfill for IDE/linter support but I think this is not needed. The tests are successful and I have tested locally with an older version of PHP 8.1 then the CI and it did not give any errors with running the linters and tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added
#[\Override]attributes, psalm default configuration checks for this https://psalm.dev/docs/running_psalm/issues/MissingOverrideAttribute/.The benefit is that PHP8.3 will throw a fatal exception when the
#[\Override]is added to a specific function but the method does not override the parent method, if the method does not exists on the parent class for example.