Skip to content

fix example with languages #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

fix example with languages #836

merged 1 commit into from
Jun 20, 2025

Conversation

dks333
Copy link
Contributor

@dks333 dks333 commented Jun 20, 2025

Documentation changes

Docs.json example with multiple languages is incorrect and misleading. This pr addresses this issue.

For Reviewers

When reviewing documentation PRs, please consider:

✅ Technical accuracy

  • Code examples work as written
  • Commands and configurations are correct
  • Links resolve to the right destinations
  • Prerequisites and requirements are accurate

✅ Clarity and completeness

  • Instructions are clear and easy to follow
  • Steps are in logical order
  • Nothing important is missing
  • Examples help illustrate the concepts

✅ User experience

  • A new user could follow these docs successfully
  • Common gotchas or edge cases are addressed
  • Error messages or troubleshooting guidance is helpful

ethanpalm
ethanpalm approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@ethanpalm ethanpalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🚀

@dks333 dks333 merged commit cf2a8de into main Jun 20, 2025
4 checks passed
@dks333 dks333 deleted the sam/fix-language-example branch June 20, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanpalm ethanpalm ethanpalm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dks333 @ethanpalm