Skip to content

nit: prefer cannonical classes#178

Merged
pqoqubbw merged 6 commits intomintlify:mainfrom
0xa3k5:main
Jan 30, 2026
Merged

nit: prefer cannonical classes#178
pqoqubbw merged 6 commits intomintlify:mainfrom
0xa3k5:main

Conversation

@0xa3k5
Copy link
Contributor

@0xa3k5 0xa3k5 commented Jan 28, 2026

Summary

replaces data-[disabled] with data-disabled to not have any unnecessary brackets on the markup 😅 super nit.


Note

Low Risk
Purely presentational attribute/class selector tweaks; primary risk is minor disabled-state styling regressions if selector semantics differ in consumers.

Overview
Updates Badge and DropdownMenuItem styling to use canonical data-disabled selectors instead of data-[disabled]/data-[disabled="true"] bracketed forms.

Badge now only renders the data-disabled attribute when disabled is true (disabled || undefined), and its disabled cursor/background/text/icon styles were updated to match the new selector syntax.

Written by Cursor Bugbot for commit 59a6883. This will update automatically on new commits. Configure here.

@dks333 dks333 requested a review from pqoqubbw January 29, 2026 00:19
@0xa3k5 0xa3k5 requested a review from pqoqubbw January 30, 2026 12:24
@pqoqubbw
Copy link
Contributor

oops, created a fix here: #182. you’ll need to pull main after this is merged 🙏

@pqoqubbw
Copy link
Contributor

there is one lint error related to your changes tho 👀

@0xa3k5
Copy link
Contributor Author

0xa3k5 commented Jan 30, 2026

@pqoqubbw you can do this too 20f6d62 but i figured its more of style so i reverted it.

@pqoqubbw
Copy link
Contributor

pqoqubbw commented Jan 30, 2026

@pqoqubbw you can do this too 20f6d62 but i figured its more of style so i reverted it.

oh nice, but let's keep it as it is for now! could you also pull the main branch please

Copy link
Contributor

@pqoqubbw pqoqubbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@pqoqubbw pqoqubbw merged commit 8e456b6 into mintlify:main Jan 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants