nit: prefer cannonical classes#178
Merged
pqoqubbw merged 6 commits intomintlify:mainfrom Jan 30, 2026
Merged
Conversation
pqoqubbw
reviewed
Jan 29, 2026
Contributor
|
oops, created a fix here: #182. you’ll need to pull main after this is merged 🙏 |
Contributor
|
there is one lint error related to your changes tho 👀 |
Contributor
Author
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
replaces
data-[disabled]withdata-disabledto not have any unnecessary brackets on the markup 😅 super nit.Note
Low Risk
Purely presentational attribute/class selector tweaks; primary risk is minor disabled-state styling regressions if selector semantics differ in consumers.
Overview
Updates
BadgeandDropdownMenuItemstyling to use canonicaldata-disabledselectors instead ofdata-[disabled]/data-[disabled="true"]bracketed forms.Badgenow only renders thedata-disabledattribute whendisabledis true (disabled || undefined), and its disabled cursor/background/text/icon styles were updated to match the new selector syntax.Written by Cursor Bugbot for commit 59a6883. This will update automatically on new commits. Configure here.