Skip to content

Tests checking that TrezorSigner produces the same signatures as SoftwareSigner #1928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

ImplOfAnImpl
Copy link
Contributor

Instead of accepting impl Rng + CryptoRng directly, signing functions now accept a more specific SigAuxDataProvider, which returns auxiliary data for bip-340 nonce generation:

  1. using random auxiliary data is what we did before and still do in the production code;
  2. using all zeros for the data is what we do in the Trezor firmware.

So, SoftwareSigner can now be parameterized with a SigAuxDataProvider, which allows the tests to force it to produce trezor-like signatures, so that TrezorSigner's signatures can be compared against them.

Base automatically changed from fill_order_dest_tests to master June 23, 2025 13:28
@ImplOfAnImpl ImplOfAnImpl merged commit b4dcc84 into master Jun 23, 2025
9 checks passed
@ImplOfAnImpl ImplOfAnImpl deleted the trezor_sig_tests branch June 23, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants