Skip to content

Commit

Permalink
update initialdelayseconds default logic
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Brennan committed Jul 24, 2024
1 parent c032320 commit defcc6c
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
4 changes: 4 additions & 0 deletions charts/standard-application-stack/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [v7.2.0] - 2024-07-24
### Changes
- Updated the logic of initialDelaySeconds to not be set if no value given

## [v7.1.0] - 2024-07-19
### Added
- Always add `matchLabelKeys: pod-template-hash` to topologySpreadConstraints
Expand Down
2 changes: 1 addition & 1 deletion charts/standard-application-stack/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 7.1.0
version: 7.2.0

dependencies:
- name: redis
Expand Down
2 changes: 1 addition & 1 deletion charts/standard-application-stack/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# standard-application-stack

![Version: 7.1.0](https://img.shields.io/badge/Version-7.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
![Version: 7.2.0](https://img.shields.io/badge/Version-7.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

A generic chart to support most common application requirements

Expand Down
8 changes: 6 additions & 2 deletions charts/standard-application-stack/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,9 @@ spec:
port: {{ .Values.liveness.port | default "http" }}
scheme: {{ .Values.liveness.scheme | default "HTTP" }}
{{- end }}
initialDelaySeconds: {{ .Values.liveness.initialDelaySeconds | default 0 }}
{{- if .Values.liveness.initialDelaySeconds }}
initialDelaySeconds: {{ .Values.liveness.initialDelaySeconds }}
{{- end }}
timeoutSeconds: {{ .Values.liveness.timeoutSeconds | default 1 }}
periodSeconds: {{ .Values.liveness.periodSeconds | default 10 }}
startupProbe:
Expand Down Expand Up @@ -325,7 +327,9 @@ spec:
port: {{ .Values.readiness.port | default "http" }}
scheme: {{ .Values.readiness.scheme | default "HTTP" }}
{{- end }}
initialDelaySeconds: {{ .Values.readiness.initialDelaySeconds | default 0 }}
{{- if .Values.readiness.initialDelaySeconds }}
initialDelaySeconds: {{ .Values.readiness.initialDelaySeconds }}
{{- end }}
timeoutSeconds: {{ .Values.readiness.timeoutSeconds | default 1 }}
periodSeconds: {{ .Values.readiness.periodSeconds | default 10 }}
{{- end }}
Expand Down

0 comments on commit defcc6c

Please sign in to comment.