-
-
Notifications
You must be signed in to change notification settings - Fork 154
Standard library additions and cleanup. #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bb25a1
to
264aab9
Compare
Remove the subject argument of the functions.
Sija
reviewed
Apr 8, 2022
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
Sija
approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment, LGTM in overall
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Needs to be documented
enhancement
New feature or request
stdlib
Standard library related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to extend, standardize and clean up the standard library modules:
Status:
AnimationFrame.mint
Array.mint
ArrayBuffer.mint
Bool.mint
Clipboard.mint
Debug.mint
Dom/Dimensions.mint
(will be a separate PR)Dom.mint
File.mint
FileSize.mint
FormData.mint
Function.mint
Html/DataTransfer.mint
Html.Event.mint
Html.mint
Html.Portals.Body.mint
Html.Portals.Head.mint
Http.mint
If.mint
IntersectionObserver.mint
Json.mint
Map.mint
Math.mint
Maybe.mint
MutationObserver.mint
Number.mint
Object/Decode.mint
Object/Encode.mint
Object/Error.mint
Promise.mint
Provider/AnimationFrame.mint
Provider/ElementSize.mint
Provider/Intersection.mint
Provider/Keydown.mint
Provider/Keyup.mint
Provider/MediaQuery.mint
Provider/Mouse.mint
Provider/Mutation.mint
Provider/OutsideClick.mint
Provider/Pointer.mint
Provider/Resize.mint
Provider/Scroll.mint
Provider/Shortcuts.mint
Provider/TabFocus.mint
Provider/Tick.mint
Provider/Url.mint
Provider/Websocket.mint
Regexp.mint
ResizeObserver.mint
Result.mint
SearchParams.mint
Set.mint
Storage/Common.mint
Storage/Local.mint
Storage/Session.mint
String.mint
(will be a separate PR for tests)Test/Context.mint
(will be a separate PR for tests)Test/Html.mint
(will be a separate PR for tests)Test/Window.mint
Time.mint
Timer.mint
Uid.mint
Unless.mint
Url.mint
Validation.mint
WebSocket.mint
Window.mint