Skip to content

Commit

Permalink
RDMA/cxgb3: Fix shift calc in build_phys_page_list() for 1-entry page…
Browse files Browse the repository at this point in the history
… lists

A single entry (addr 0x10001000, size 0x2000) will get converted to
page address 0x10000000 with a page size of 0x4000.  The code as it
stands doesn't address the single buffer case, but in fact it allows
the subsequent single-buffer special case to be eliminated entirely.
Because the mask now includes the (page adjusted) starting and ending
addresses, the general case works for the single buffer case as well.

Signed-off-by: Bryan Rosenburg <rosnbrg@us.ibm.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
rosnbrg authored and Roland Dreier committed Feb 26, 2008
1 parent bfa274e commit 82d416f
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/infiniband/hw/cxgb3/iwch_mem.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,8 @@ int build_phys_page_list(struct ib_phys_buf *buffer_list,

/* Find largest page shift we can use to cover buffers */
for (*shift = PAGE_SHIFT; *shift < 27; ++(*shift))
if (num_phys_buf > 1) {
if ((1ULL << *shift) & mask)
break;
} else
if (1ULL << *shift >=
buffer_list[0].size +
(buffer_list[0].addr & ((1ULL << *shift) - 1)))
break;
if ((1ULL << *shift) & mask)
break;

buffer_list[0].size += buffer_list[0].addr & ((1ULL << *shift) - 1);
buffer_list[0].addr &= ~0ull << *shift;
Expand Down

0 comments on commit 82d416f

Please sign in to comment.