Skip to content

Commit

Permalink
[MTD] [DOC200x] eccbuf is statically defined and always evaluate to true
Browse files Browse the repository at this point in the history
Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
samueltardieu authored and dwmw2 committed Feb 7, 2008
1 parent d547668 commit 53fb84a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions drivers/mtd/devices/doc2000.c
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ static int doc_read(struct mtd_info *mtd, loff_t from, size_t len,
len = ((from | 0x1ff) + 1) - from;

/* The ECC will not be calculated correctly if less than 512 is read */
if (len != 0x200 && eccbuf)
if (len != 0x200)
printk(KERN_WARNING
"ECC needs a full sector read (adr: %lx size %lx)\n",
(long) from, (long) len);
Expand Down Expand Up @@ -896,7 +896,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len,
/* Let the caller know we completed it */
*retlen += len;

if (eccbuf) {
{
unsigned char x[8];
size_t dummy;
int ret;
Expand Down
2 changes: 1 addition & 1 deletion drivers/mtd/devices/doc2001plus.c
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,7 @@ static int doc_write(struct mtd_info *mtd, loff_t to, size_t len,
WriteDOC(DoC_GetDataOffset(mtd, &fto), docptr, Mplus_FlashCmd);

/* On interleaved devices the flags for 2nd half 512 are before data */
if (eccbuf && before)
if (before)
fto -= 2;

/* issue the Serial Data In command to initial the Page Program process */
Expand Down

0 comments on commit 53fb84a

Please sign in to comment.