Fix condition for safePageWait in GeneralTest::testAdvancedForm #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...cause both pages have a title and we are on the new/submitted page if title is "Advanced form save".
robertfausk
changed the title
Member
|
Makes sense. I don't recall, that we'd had any issues with previous implementation though (e.g. redirect after submit, that wasn't made wasn't causing test to fail). |
robertfausk
added a commit
to robertfausk/mink-panther-driver
that referenced
this pull request
Oct 8, 2020
cause minkphp/driver-testsuite#35 was merged finally :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...cause both pages have a title and we are on the new/submitted page if title is "Advanced form save".
Form page:
driver-testsuite/web-fixtures/advanced_form.html
Line 4 in d208035
Submitted page:
driver-testsuite/web-fixtures/advanced_form_post.php
Line 4 in d208035
Edit: Added file preview.