fix: more permission retrieval references

Signed-off-by: Suhayb Wardany <me@suw.me>
ministryofjustice · Sep 25, 2019 · aae68ea · aae68ea
1 parent fabccf9
commit aae68ea
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/Permissions/StandardPermissions.php b/src/Permissions/StandardPermissions.php
@@ -31,16 +31,16 @@ protected function createPreparedPermissions(): array
     {
         $prepared = [];
 
-        if (! empty($this->secondaryPermissions)) {
-            foreach ($this->secondaryPermissions as $permissions) {
+        if (! empty($this->getSecondaryPermissions())) {
+            foreach ($this->getSecondaryPermissions() as $permissions) {
                 $this->preparePermissions($prepared, $permissions);
             }
         }
 
-        if (! empty($this->permissions)) {
+        if (! empty($this->getPermissions())) {
             $permissions = [];
 
-            $this->preparePermissions($permissions, $this->permissions);
+            $this->preparePermissions($permissions, $this->getPermissions());
 
             $prepared = array_merge($prepared, $permissions);
         }

diff --git a/src/Permissions/StrictPermissions.php b/src/Permissions/StrictPermissions.php
@@ -31,14 +31,14 @@ protected function createPreparedPermissions(): array
     {
         $prepared = [];
 
-        if (! empty($this->secondaryPermissions)) {
-            foreach ($this->secondaryPermissions as $permissions) {
+        if (! empty($this->getSecondaryPermissions())) {
+            foreach ($this->getSecondaryPermissions() as $permissions) {
                 $this->preparePermissions($prepared, $permissions);
             }
         }
 
-        if (! empty($this->permissions)) {
-            $this->preparePermissions($prepared, $this->permissions);
+        if (! empty($this->getPermissions())) {
+            $this->preparePermissions($prepared, $this->getPermissions());
         }
 
         return $prepared;

diff --git a/tests/Permissions/PermissionsTraitTest.php b/tests/Permissions/PermissionsTraitTest.php
@@ -118,8 +118,8 @@ protected function createPreparedPermissions()
     {
         $prepared = [];
 
-        if (! empty($this->secondaryPermissions)) {
-            foreach ($this->secondaryPermissions as $permissions) {
+        if (! empty($this->getSecondaryPermissions())) {
+            foreach ($this->getSecondaryPermissions() as $permissions) {
                 $this->preparePermissions($prepared, $permissions);
             }
         }