Apply suggestions from code review

Co-Authored-By: Bruno Gaspar <brunofgaspar1@gmail.com>
ministryofjustice · Sep 10, 2019 · 98e17aa · 98e17aa
1 parent 53648c0
commit 98e17aa
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 0 deletions.
diff --git a/tests/Activations/IlluminateActivationRepositoryTest.php b/tests/Activations/IlluminateActivationRepositoryTest.php
@@ -51,6 +51,9 @@ class IlluminateActivationRepositoryTest extends TestCase
      */
     protected $query;
 
+    /**
+     * {@inheritdoc}
+     */
     protected function setUp(): void
     {
         $this->query = m::mock(Builder::class);
@@ -70,6 +73,7 @@ protected function tearDown(): void
         $this->query       = null;
         $this->model       = null;
         $this->activations = null;
+
         m::close();
     }
 

diff --git a/tests/Checkpoints/ActivationCheckpointTest.php b/tests/Checkpoints/ActivationCheckpointTest.php
@@ -68,6 +68,7 @@ protected function tearDown(): void
         $this->activations = null;
         $this->user        = null;
         $this->checkpoint  = null;
+
         m::close();
     }
 

diff --git a/tests/Checkpoints/ThrottleCheckpointTest.php b/tests/Checkpoints/ThrottleCheckpointTest.php
@@ -69,6 +69,7 @@ protected function tearDown(): void
         $this->throttle   = null;
         $this->user       = null;
         $this->checkpoint = null;
+
         m::close();
     }
 

diff --git a/tests/Permissions/PermissibleTraitTest.php b/tests/Permissions/PermissibleTraitTest.php
@@ -43,6 +43,7 @@ protected function setUp(): void
     protected function tearDown(): void
     {
         $this->permissible = null;
+
         m::close();
     }
 

diff --git a/tests/Persistences/EloquentPersistenceTest.php b/tests/Persistences/EloquentPersistenceTest.php
@@ -53,6 +53,7 @@ protected function setUp(): void
     protected function tearDown(): void
     {
         $this->persistence = null;
+
         m::close();
     }
 

diff --git a/tests/Reminders/IlluminateReminderRepositoryTest.php b/tests/Reminders/IlluminateReminderRepositoryTest.php
@@ -83,6 +83,7 @@ protected function tearDown(): void
         $this->query     = null;
         $this->model     = null;
         $this->reminders = null;
+
         m::close();
     }
 

diff --git a/tests/Roles/EloquentRoleTest.php b/tests/Roles/EloquentRoleTest.php
@@ -47,6 +47,7 @@ protected function setUp(): void
     protected function tearDown(): void
     {
         $this->role = null;
+
         m::close();
     }
 

diff --git a/tests/Users/IlluminateUserRepositoryTest.php b/tests/Users/IlluminateUserRepositoryTest.php
@@ -57,6 +57,7 @@ protected function tearDown(): void
         $this->query  = null;
         $this->model  = null;
         $this->users  = null;
+
         m::close();
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -43,6 +43,7 @@ protected function setUp(): void @@
         protected function tearDown(): void
         {
             $this->permissible = null;
             m::close();
         }
@@ Expand Down @@