Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚫 Ignore Import Order False Positives #5020

Merged
merged 2 commits into from
Nov 13, 2024
Merged

🚫 Ignore Import Order False Positives #5020

merged 2 commits into from
Nov 13, 2024

Conversation

PepperMoJ
Copy link
Contributor

@PepperMoJ PepperMoJ commented Nov 13, 2024

👀 Purpose

We are getting false positives on import order linting. This is due to a known issue with isort.

Also pinned some action versions that were failing our check.

♻️ What's Changed

  • Ignores added for C0411 on relevant files.
  • Pinned failing action versions.

📝 Notes

No notes!


✅ Things to Check (Optional)

  • I have run all unit tests, and they pass.
  • I have ensured my code follows the project's coding standards.
  • I have checked that all new dependencies are up to date and necessary.

@PepperMoJ PepperMoJ requested a review from a team as a code owner November 13, 2024 15:14
Copy link
Contributor

github-actions bot commented Nov 13, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ PYTHON flake8 2 0 0.44s
✅ PYTHON isort 2 2 0 0.31s
✅ PYTHON pylint 2 0 2.71s
✅ REPOSITORY gitleaks yes no 1.63s
✅ YAML prettier 2 0 0 0.42s
✅ YAML yamllint 2 0 0.32s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

levgorbunov1
levgorbunov1 previously approved these changes Nov 13, 2024
@levgorbunov1 levgorbunov1 dismissed their stale review November 13, 2024 15:16

version pinning

Copy link
Contributor

@tamsinforbes tamsinforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌝🌖🚀LGTM🚀🌘🌚

@PepperMoJ PepperMoJ merged commit 2796247 into main Nov 13, 2024
7 checks passed
@PepperMoJ PepperMoJ deleted the megalinter-fixes branch November 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants