Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Microsoft Auth0 prod app #4717

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Add Microsoft Auth0 prod app #4717

merged 4 commits into from
Aug 7, 2024

Conversation

tamsinforbes
Copy link
Contributor

👀 Purpose

• ✨ Add Microsoft Authentication prod app

♻️ What's Changed

• ✨ Add Microsoft Authentication prod app

📝 Notes

•

✅ Things to Check (Optional)

  • I have run all unit tests, and they pass.
  • I have ensured my code follows the project's coding standards.
  • I have checked that all new dependencies are up to date and necessary.

@tamsinforbes tamsinforbes self-assigned this Aug 7, 2024
@tamsinforbes tamsinforbes linked an issue Aug 7, 2024 that may be closed by this pull request
🚨 Rotate Join GitHub EntraId Secret Before 12/08/2024 #4667
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Your PR is applying here: https://github.com/ministryofjustice/operations-engineering/actions/workflows/cicd-terraform-auth0.yml?query=event%3Apush+branch%3Amain

@tamsinforbes tamsinforbes marked this pull request as ready for review August 7, 2024 13:39
@tamsinforbes tamsinforbes requested a review from a team as a code owner August 7, 2024 13:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ REPOSITORY gitleaks yes no 1.1s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

connormaglynn
connormaglynn approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@connormaglynn connormaglynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks Good To Me!

@tamsinforbes tamsinforbes merged commit d14f861 into main Aug 7, 2024
7 checks passed
@tamsinforbes tamsinforbes deleted the add-ms-auth0-prod-app branch August 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connormaglynn connormaglynn connormaglynn approved these changes

Assignees

@tamsinforbes tamsinforbes

Labels
None yet
Projects
⚙️ Operations Engineering
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚨 Rotate Join GitHub EntraId Secret Before 12/08/2024
2 participants
@tamsinforbes @connormaglynn