Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds guide to explain r53 resolver dns firewall configuration applied to MP VPCs #9485

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

richgreen-moj
Copy link
Contributor

A reference to the issue / Description of it

#9037

How does this PR fix the problem?

This PR adds a guide to explain the R53 resolver dns firewall configuration applied to MP VPCs

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@richgreen-moj richgreen-moj requested a review from a team as a code owner March 6, 2025 11:41
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:

Copy link
Contributor

@markgov markgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but did ponder over the then we will over we will then in the alerting section

@richgreen-moj richgreen-moj added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit ec9e5e3 Mar 6, 2025
5 checks passed
@richgreen-moj richgreen-moj deleted the docs/9037-r53-dns-firewall branch March 6, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants