Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM457-2221: Remove redundant pub-sub mechanism #339

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

patrick-laa
Copy link
Contributor

Description of change

Now that neither provider nor caseworker relies on pub/sub we can remove the mechanism entirely.

Link to relevant ticket

@patrick-laa patrick-laa marked this pull request as ready for review December 6, 2024 17:29
@patrick-laa patrick-laa requested a review from a team as a code owner December 6, 2024 17:29
Copy link

sonarqubecloud bot commented Dec 6, 2024

Copy link
Contributor

@elken elken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love seeing so many removed lines.

I'm sure you are; but are you sure this is all the places where we do pub-sub in the app store? Approved based on the assumption you have.

@patrick-laa patrick-laa merged commit 30d4f3b into main Dec 9, 2024
11 checks passed
@patrick-laa patrick-laa deleted the CRM457-2221-tidyup branch December 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants