Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5877: Add ApplicationDigest csv to admin report #7724

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

naseberry
Copy link
Contributor

What

Add ApplicationDigest CSV to admin reports

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake.
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The development standards and Git Workflow documentation on Confluence should be followed.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@naseberry naseberry marked this pull request as ready for review March 27, 2025 14:08
@naseberry naseberry requested a review from a team as a code owner March 27, 2025 14:08
@naseberry naseberry force-pushed the ap-5877-application-digest-admin-report branch 2 times, most recently from 7960680 to ed05308 Compare March 27, 2025 15:04
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, one essential, several minor content issues

@naseberry naseberry force-pushed the ap-5877-application-digest-admin-report branch 2 times, most recently from 561b66e to 412bdcb Compare April 2, 2025 08:05
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good to me

@jsugarman jsugarman self-requested a review April 4, 2025 07:09
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updates LGTM 👍

@naseberry naseberry force-pushed the ap-5877-application-digest-admin-report branch from 412bdcb to 3679516 Compare April 4, 2025 12:30
Copy link

sonarqubecloud bot commented Apr 4, 2025

@naseberry naseberry merged commit 0ce1e7f into main Apr 4, 2025
15 checks passed
@naseberry naseberry deleted the ap-5877-application-digest-admin-report branch April 4, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants