AP-5828: Editing applications feasibility spike #7711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsugarman
force-pushed
the
ap-5828/editing-applications-feasibility-spike
branch
6 times, most recently
from
765d902 to
ff7e985
Compare
Spike using NSCC task list but modified and then customised to handle validating all forms and or models via the notion of a "task validator".
This inherits from the base_state_machine but overrides its `aasm` block, thereby not implementing ANY states and events. This may allow us to build up the state machine in isolation and transfer only what is needed. It allows the CYA flow to continue as is, but if the users returns to the task list then its behavior reverts to the primary/first-pass flow. This kind of what we want, but designers may want the task list flow to be go back to the task list between tasks when editing completed tasks.
This has the advantage of making the data elements immutable and can combine multiple attributes and, if needed in the future, add methods to the Data object itself.
jsugarman
force-pushed
the
ap-5828/editing-applications-feasibility-spike
branch
from
ff7e985 to
0e38a40
Compare
When no name has been added yet but user navigates back to list of applications we specify "not provided" for the name, rather than current unhandled behaviour that displays a link for the name
This implements latest classes from the [design system](https://design-system.service.gov.uk/components/task-list/) which ensures right alignment. I guess this came out of latest front-end changes?!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Spike to investigate editing applications
Link to story
Checklist
Before you ask people to review this PR:
bundle exec rake.git rebase main.