Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

118 custom configurations per kind #125

Merged
merged 6 commits into from
Jul 2, 2021

Conversation

miniscruff
Copy link
Owner

@miniscruff miniscruff commented Jun 28, 2021

Check the following

  • Keep 100% code coverage
  • Be properly formatted
  • Have no linting errors
  • Documentation changes are included
  • Include a change file if expected

This is just a refactoring PR so no changes, will make another PR for #118

@miniscruff miniscruff self-assigned this Jun 28, 2021
@vercel
Copy link

vercel bot commented Jun 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/miniscruff/changie/8JeUu3jW1N1b1gYoYCjYsU1ykHT8
✅ Preview: https://changie-git-118-custom-configurations-per-kind-miniscruff.vercel.app

@codecov
Copy link

codecov bot commented Jun 28, 2021

Codecov Report

Merging #125 (65ed4bb) into main (7b56cd9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #125   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        13    +2     
  Lines          423       425    +2     
=========================================
+ Hits           423       425    +2     
Impacted Files Coverage Δ
cmd/init.go 100.00% <ø> (ø)
cmd/batch.go 100.00% <100.00%> (ø)
cmd/latest.go 100.00% <100.00%> (ø)
cmd/merge.go 100.00% <100.00%> (ø)
cmd/new.go 100.00% <100.00%> (ø)
cmd/next.go 100.00% <100.00%> (ø)
core/change.go 100.00% <100.00%> (ø)
core/config.go 100.00% <100.00%> (ø)
core/custom.go 100.00% <100.00%> (ø)
core/replacement.go 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b56cd9...65ed4bb. Read the comment docs.

@miniscruff miniscruff added the skip changelog Non-user impacting change label Jun 28, 2021
@miniscruff miniscruff marked this pull request as ready for review July 2, 2021 07:51
@miniscruff miniscruff merged commit 5c75177 into main Jul 2, 2021
@miniscruff miniscruff deleted the 118-custom-configurations-per-kind branch July 2, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Non-user impacting change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant