first steps deleting images #13
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented that the images get deleted after usage.
The problem is now that everything gets downloaded every time. However this doesn't happen without my changes. That means that there's some point where the code checks if the stuff has already been downloaded. If we could find that point, we could check if the stuff is being downloaded the first time and then not deleting it. That way it would only be downloaded the first time, this will then be copied for every new container and then this image can be deleted after usage.
I need help with that point, I really tried to find that point for a while and couldn't introduce what I was thinking of. ORCA with gemini couldn't help me with that either.
These are now only the changes that currently work as described above.