Improve marshal speed #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fast case for non-escaped inputs. Escaped values take a small penalty, but it seems like an overall gain. ``` benchmark old ns/op new ns/op delta BenchmarkIter_MarshalJSONBuffer/apache_builds-32 287323 152872 -46.79% BenchmarkIter_MarshalJSONBuffer/canada-32 13529136 13336691 -1.42% BenchmarkIter_MarshalJSONBuffer/citm_catalog-32 1727759 1285843 -25.58% BenchmarkIter_MarshalJSONBuffer/github_events-32 147846 72136 -51.21% BenchmarkIter_MarshalJSONBuffer/gsoc-2018-32 7302709 3198392 -56.20% BenchmarkIter_MarshalJSONBuffer/instruments-32 405617 247097 -39.08% BenchmarkIter_MarshalJSONBuffer/numbers-32 1114819 1098031 -1.51% BenchmarkIter_MarshalJSONBuffer/marine_ik-32 15554551 14718475 -5.38% BenchmarkIter_MarshalJSONBuffer/mesh-32 4519934 4387538 -2.93% BenchmarkIter_MarshalJSONBuffer/mesh.pretty-32 4542054 4366635 -3.86% BenchmarkIter_MarshalJSONBuffer/twitterescaped-32 1361729 655030 -51.90% BenchmarkIter_MarshalJSONBuffer/twitter-32 1361365 650635 -52.21% BenchmarkIter_MarshalJSONBuffer/random-32 1593711 933206 -41.44% BenchmarkIter_MarshalJSONBuffer/update-center-32 1599886 781166 -51.17% benchmark old MB/s new MB/s speedup BenchmarkIter_MarshalJSONBuffer/apache_builds-32 329.43 619.17 1.88x BenchmarkIter_MarshalJSONBuffer/canada-32 154.50 156.73 1.01x BenchmarkIter_MarshalJSONBuffer/citm_catalog-32 289.57 389.08 1.34x BenchmarkIter_MarshalJSONBuffer/github_events-32 360.71 739.29 2.05x BenchmarkIter_MarshalJSONBuffer/gsoc-2018-32 420.40 959.87 2.28x BenchmarkIter_MarshalJSONBuffer/instruments-32 267.03 438.34 1.64x BenchmarkIter_MarshalJSONBuffer/numbers-32 134.66 136.72 1.02x BenchmarkIter_MarshalJSONBuffer/marine_ik-32 117.59 124.27 1.06x BenchmarkIter_MarshalJSONBuffer/mesh-32 142.19 146.48 1.03x BenchmarkIter_MarshalJSONBuffer/mesh.pretty-32 141.50 147.18 1.04x BenchmarkIter_MarshalJSONBuffer/twitterescaped-32 342.88 712.80 2.08x BenchmarkIter_MarshalJSONBuffer/twitter-32 342.97 717.62 2.09x BenchmarkIter_MarshalJSONBuffer/random-32 289.55 494.50 1.71x BenchmarkIter_MarshalJSONBuffer/update-center-32 333.12 682.26 2.05x ```
klauspost
force-pushed
the
faster-string-escaping
branch
from
5b9bca5 to
4e970fb
Compare
harshavardhana
approved these changes
Nov 24, 2021
# Conflicts: # parsed_json_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.