throw error on number overflow #25
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
reviewed
Jan 15, 2021
| @@ -38,6 +39,12 @@ func parse_number_simd(buf []byte, found_minus bool) (success, is_double bool, d | |||
| } | |||
|
|
|||
| var err error | |||
| // check if number would overflow | |||
| _, err = strconv.ParseUint(string(buf[:pos]), 10, 64) | |||
There was a problem hiding this comment.
This seems to prevent big numbers to be returned as floats.
These 2 unit tests fail when this is in place:
So this cannot be used as-is. I will take a look at this piece of code and see what can be done.
|
You led me down quite a rabbit hole. See #27 If you need integers for specific fields you will have to check the returned types, however now it will also return uint64s in case they fit. |
klauspost
added a commit
to klauspost/simdjson-go-1
that referenced
this pull request
Jan 22, 2021
As flag to tape that indicates that an integer was converted to float due to int64/uint64 limits. Fixes minio#25
harshavardhana
pushed a commit
that referenced
this pull request
Jan 25, 2021
As flag to tape that indicates that an integer was converted to float due to int64/uint64 limits. Fixes #25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.