Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not create resources for marked deleted tenant #2310

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 4, 2024

fix: will not create anything for marked deleted tenant

shtripat
shtripat previously approved these changes Sep 4, 2024
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we have steps to verify the changes locally?

@jiuker
Copy link
Contributor Author

jiuker commented Sep 4, 2024

LGTM. Can we have steps to verify the changes locally?

You can deploy tenant with finalizer. And then delete it @shtripat

@pjuarezd
Copy link
Member

pjuarezd commented Sep 4, 2024

LGTM. Can we have steps to verify the changes locally?

You can deploy tenant with finalizer. And then delete it @shtripat

which finalizer @jiuker?

@jiuker
Copy link
Contributor Author

jiuker commented Sep 5, 2024

LGTM. Can we have steps to verify the changes locally?

You can deploy tenant with finalizer. And then delete it @shtripat

which finalizer @jiuker?

Looks like we need other operator change the service finalizer...

pkg/controller/main-controller.go Outdated Show resolved Hide resolved
jiuker and others added 2 commits September 10, 2024 23:18
fix: will not create anything for marked deleted tenant
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana changed the title fix: will not create anything for marked deleted tenant fix: do not create resources for marked deleted tenant Sep 11, 2024
@harshavardhana harshavardhana merged commit 59dd68e into minio:master Sep 11, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants