-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not create resources for marked deleted tenant #2310
fix: do not create resources for marked deleted tenant #2310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we have steps to verify the changes locally?
You can deploy tenant with finalizer. And then delete it @shtripat |
fix: will not create anything for marked deleted tenant
Co-authored-by: Pedro Juarez <pjuarezd@users.noreply.github.com>
9103108
to
1685eac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fix: will not create anything for marked deleted tenant