Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mixed the minioJob/policybinding/sts namespace #2291

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Aug 26, 2024

fix: mixed the minioJob/policybinding/sts namespace
fix #2290
see

// Authorized PolicyBindings for the Service Account
policyBindings := []v1beta1.PolicyBinding{}
pbs, err := c.minioClientSet.StsV1beta1().PolicyBindings(tenantNamespace).List(ctx, metav1.ListOptions{})
if err != nil {
writeSTSErrorResponse(w, true, ErrSTSInternalError, fmt.Errorf("Error obtaining PolicyBindings: %s", err))
return
}
for _, pb := range pbs.Items {
if pb.Spec.Application.Namespace == saNamespace && pb.Spec.Application.ServiceAccount == saName {
policyBindings = append(policyBindings, pb)
}

fix: mixed the minioJob/policybinding/sts namespace
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 45110b9 into minio:master Aug 26, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinIOJob with Tenant in different namespace not working
3 participants