Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fullname from helm chart since nothing uses it #2242

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

dvaldivia
Copy link
Collaborator

No description provided.

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@ramondeklein ramondeklein self-requested a review July 26, 2024 08:37
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the code if we really need this name to be fixed, but there are not a lot of places where we need this name to be fixed. The controller.getOperatorDeploymentName() function looks like this (source):

func getOperatorDeploymentName() string {
        // NOTE: constants expanded for clarity in this PR
	return env.Get("MINIO_OPERATOR_DEPLOYMENT_NAME", "minio-operator")
}

I don't think this name needs to be fixed, if we also set the MINIO_OPERATOR_DEPLOYMENT_NAME environment variable properly and set the name here. According to the documentation this is a support scenario (that probably doesn't work properly anymore for a while). It should be tested though.

It's fine by me to hardcode the name, but then we should remove this environment variable from code and update the documentation too.

@harshavardhana
Copy link
Member

func getOperatorDeploymentName() string {
        // NOTE: constants expanded for clarity in this PR
	return env.Get("MINIO_OPERATOR_DEPLOYMENT_NAME", "minio-operator")
}

@dvaldivia ^^

@ramondeklein
Copy link
Contributor

@dvaldivia I think we should remove the environment variable if we decide to use a fixed name. That's why I didn't approve this change. I'ld be happy to remove this variable in this PR...

@harshavardhana
Copy link
Member

@dvaldivia I think we should remove the environment variable if we decide to use a fixed name. That's why I didn't approve this change. I'ld be happy to remove this variable in this PR...

@ramondeklein please send it separately, this PR can be merged as is.

@harshavardhana harshavardhana merged commit 28d4cd6 into minio:master Sep 19, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants