Skip to content

Release 5.0.15 #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Release 5.0.15 #2077

wants to merge 1 commit into from

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Apr 18, 2024

Objective:

To create new tag: Release 5.0.15

Reasoning:

We want to begin showcasing the new MinIOJob functionality.

Documentation:

https://github.com/minio/operator/wiki/How-to-make-Operator-Release

Additional Information:

We broke upgrade test when deprecating the plugin in #2051, I am attempting to fix it by doing this:

Screenshot 2024-04-18 at 6 56 19 PM

Needed:

#2078

@cniackz cniackz requested review from pjuarezd and allanrogerr April 18, 2024 21:58
@cniackz cniackz self-assigned this Apr 18, 2024
@cniackz cniackz added the release When we have a new release label Apr 18, 2024
@cniackz cniackz requested review from dvaldivia and jiuker April 18, 2024 22:01
@cniackz
Copy link
Contributor Author

cniackz commented Apr 18, 2024

Is it normal to encounter an ErrImagePull error during the creation of a new tag in the Tenant upgrade test on Kind?

NAME                              READY   STATUS         RESTARTS   AGE
console-6b5857755b-cxtgg          0/1     ErrImagePull   0          10s
minio-operator-5d56c445bf-bf88r   0/1     ErrImagePull   0          10s
minio-operator-5d56c445bf-jdd9t   0/1     ErrImagePull   0          10s
Waiting for Operator Pods to come online (2m timeout)
timed out waiting for the condition on pods/minio-operator-5d56c445bf-bf88r
timed out waiting for the condition on pods/minio-operator-5d56c445bf-jdd9t
/home/runner/work/operator/operator/testing/deploy-tenant-upgrade.sh: cannot kubectl wait --namespace minio-operator --for=condition=ready pod --selector name=minio-operator --timeout=120s
Deleting cluster "kind" ...

@cniackz
Copy link
Contributor Author

cniackz commented Apr 18, 2024

Test has been fixed, but don't merge until we get #2078 in

@pjuarezd
Copy link
Member

Test has been fixed, but don't merge until we get #2078 in

Don't worry @cniackz we can merge this even without #2078, would be nice, but just that a nice to have :)

Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, but not sure if they are important. Is there some way we could use some kind of preprocessor to make this less error prone? The version number and Docker images are repeated very often and I guess it's now a search & replace upgrade.

BTW: This release procedure is a nightmare. How often does RedHat release new versions and do we need to do this?

@@ -5,6 +5,6 @@ annotations:
operators.operatorframework.io.bundle.metadata.v1: metadata/
operators.operatorframework.io.bundle.package.v1: minio-operator-rhmp
operators.operatorframework.io.bundle.channels.v1: stable
operators.operatorframework.io.metrics.builder: operator-sdk-v1.22.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use a custom release (v1.28.0-ocp) instead of a regular baseline release? Latest release is v1.34.0 btw...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good find. I need to update my local version to prevent any setbacks. Let me take care of that. Thanks, guys!

@@ -601,10 +601,10 @@ function install_operator_version() {
if [ -z "$version" ]; then
version=$(curl https://api.github.com/repos/minio/operator/releases/latest | jq --raw-output '.tag_name | "\(.[1:])"')
fi
echo "Target operator release: $version"
echo "Target operator release: $version" # version value example is 5.0.14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 5.0.15?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. Im not sure that we need to leave a hardcoded value in a comment but I suppose this is just an example.

In this test and specific PR deploy-tenant-upgrade.sh, we are comparing the latest Operator release (5.0.14) to the current branch of Operator (master).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason I mentioned it is that I suspect that a next version will do a search on 5.0.15 and this may be left on 5.0.14 forever. Not a real issue for comments, but it may look a bit sloppy. I would keep that on the latest version, so it will be replaced too and kept up-to-date.

@allanrogerr
Copy link
Contributor

LGTM - just some small observations to take offline

@cniackz cniackz closed this Apr 19, 2024
@cniackz cniackz deleted the operator-release branch April 19, 2024 14:23
@cniackz
Copy link
Contributor Author

cniackz commented Apr 19, 2024

I will address all things in a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release When we have a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants