Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize Examples to use a consitent name #1496

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Organize Examples to use a consitent name #1496

merged 2 commits into from
Mar 11, 2023

Conversation

dvaldivia
Copy link
Collaborator

  • Re-organizing all the examples to have a consistent tenant name myminio.
  • Each example will remain with it's own unique namespace so users can still install all of them at once if they want to.
  • Updated all the test code to use the common name, this reduces complexity.
  • Updated all documentation to use this name

@dvaldivia dvaldivia self-assigned this Mar 10, 2023
ravindk89
ravindk89 previously approved these changes Mar 10, 2023
View reviewed changes
@allanrogerr
Copy link
Contributor

Builds failing @dvaldivia . Perhaps your already looking into this

reivaj05
reivaj05 previously approved these changes Mar 10, 2023
View reviewed changes
@dvaldivia dvaldivia dismissed stale reviews from reivaj05 and ravindk89 via d94ba8f March 10, 2023 22:53
@dvaldivia
Organize Examples to use a consitent name
adc5783 
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dvaldivia
react lint
8c06571 
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@dilverse dilverse merged commit 707431a into minio:master Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilverse dilverse dilverse approved these changes

@pjuarezd pjuarezd pjuarezd approved these changes

@ravindk89 ravindk89 ravindk89 left review comments

@reivaj05 reivaj05 reivaj05 left review comments

@cniackz cniackz Awaiting requested review from cniackz

@allanrogerr allanrogerr Awaiting requested review from allanrogerr

@bexsoft bexsoft Awaiting requested review from bexsoft

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@dvaldivia dvaldivia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dvaldivia @allanrogerr @pjuarezd @reivaj05 @ravindk89 @dilverse