Fix share link issue (#3382) #3384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
reviewed
Jun 13, 2024
There was a problem hiding this comment.
@ramondeklein could you please add a test for it 🙏 , we have tests already for this function.
ramondeklein
force-pushed
the
fix-share-file-3382
branch
from
457c894 to
7e0592a
Compare
ramondeklein
force-pushed
the
fix-share-file-3382
branch
from
7e0592a to
cd00cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3382 . The URL router cannot deal with path-encoded parameters properly, so we'll use query-encoding instead. This also encodes colons, equal signs, ... and this fixes this issue.