Return header with error idp logout #3346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjuarezd
force-pushed
the
return-header-with-error-idp-logout
branch
from
de0901f to
e493a4e
Compare
pjuarezd
force-pushed
the
return-header-with-error-idp-logout
branch
from
e493a4e to
8822e5b
Compare
pjuarezd
requested review from
adriangitvitz,
bayasdev,
bexsoft,
cesnietor,
dvaldivia,
jinapurapu and
reivaj05
harshavardhana
approved these changes
May 11, 2024
prakashsvmx
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3225
What does this do?
The problem with Logout from IDP is that we are silently failing if for some external reason non related to Console the
end_session_endpointcannot be reached, this PR adds a way to get insights on the problem without sacrifice the idempotence of logout.Add a response header to the
api/v1/logoutendpoint when the underneath call to logout from the IDP fails.The header will not be shown when IDP logout is success.
How does it look?