Kms status endpoints null validation #3189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
requested review from
allanrogerr,
bexsoft,
cniackz,
dvaldivia,
kaankabalak and
pjuarezd
cesnietor
force-pushed
the
kms-status-endpoints-null-validation
branch
from
8eda296 to
1c8e139
Compare
kaankabalak
reviewed
Jan 12, 2024
cesnietor
force-pushed
the
kms-status-endpoints-null-validation
branch
2 times, most recently
from
a81adff to
dc990fd
Compare
cesnietor
force-pushed
the
kms-status-endpoints-null-validation
branch
from
dc990fd to
215f3b8
Compare
cniackz
approved these changes
Jan 12, 2024
bexsoft
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If for some reason the kms/status api returns null in endpoints, it was breaking the Encryption Screen so this adds a type check.
Before:
Blank Screen
After:
