Change Loading Logic for Metrics Page #3166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
bexsoft
approved these changes
Dec 22, 2023
harshavardhana
approved these changes
Dec 22, 2023
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an ongoing problem where we display an error for the dashboard page every time we load it directly via browser url or hit refresh on that page.
This fixes it by introducing a third loading state so that the internal functions know when to properly perform their own checks.
Also sets the order of the tabs to always start with Info