Skip to content

Cleaned up Tooltips and HelpTips on AddBucket screen #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Cleaned up Tooltips and HelpTips on AddBucket screen #3154

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3a273a
Cleaned up overlapping tooltips, moved content into HelpTips
Dec 7, 2023
2d50a73
Merge branch 'master' into helptip_improvement
prakashsvmx Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/AddBucket.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,7 @@ const AddBucket = () => {
}
tooltip={
versioningAllowed
? lockingEnabled && versioningEnabled
? "You must disable Locking before Versioning can be disabled"
: ""
? ""
: permissionTooltipHelper(
[
IAM_SCOPES.S3_PUT_BUCKET_VERSIONING,
Expand All @@ -352,12 +350,19 @@ const AddBucket = () => {
}
helpTip={
<Fragment>
{lockingEnabled && versioningEnabled && (
<strong>
{" "}
You must disable Object Locking before Versioning can
be disabled <br />
</strong>
)}
MinIO supports keeping multiple{" "}
<a
href="https://min.io/docs/minio/kubernetes/upstream/administration/object-management/object-versioning.html#minio-bucket-versioning"
target="blank"
>
“versions”
versions
</a>{" "}
of an object in a single bucket.
<br />
Expand Down Expand Up @@ -399,6 +404,7 @@ const AddBucket = () => {
from versioning if Object Locking is not enabled.
<br />
MinIO requires versioning to support replication.
<br />
Objects in excluded prefixes do not replicate to any
peer site or remote site.
</Fragment>
Expand Down Expand Up @@ -440,11 +446,7 @@ const AddBucket = () => {
label={"Object Locking"}
tooltip={
lockingAllowed
? `${
versioningEnabled
? "Exclude Folders & Exclude Prefixes options will not be available if this option is enabled."
: ""
}`
? ``
: permissionTooltipHelper(
[
IAM_SCOPES.S3_PUT_BUCKET_VERSIONING,
Expand All @@ -456,6 +458,13 @@ const AddBucket = () => {
}
helpTip={
<Fragment>
{retentionEnabled && (
<strong>
{" "}
You must disable Retention before Object Locking can
be disabled <br />
</strong>
)}
You can only enable{" "}
<a
href="https://min.io/docs/minio/macos/administration/object-management.html#object-retention"
Expand All @@ -464,6 +473,12 @@ const AddBucket = () => {
Object Locking
</a>{" "}
when first creating a bucket.
<br />
<br />
<a href="https://min.io/docs/minio/windows/administration/object-management/object-versioning.html#exclude-folders-from-versioning">
Exclude folders and prefixes
</a>{" "}
options will not be available if this option is enabled.
</Fragment>
}
helpTipPlacement="right"
Expand Down