-
Notifications
You must be signed in to change notification settings - Fork 495
Improved error handling in Object Browser #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| // This file is part of MinIO Console Server | ||
| // Copyright (c) 2023 MinIO, Inc. | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU Affero General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU Affero General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU Affero General Public License | ||
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| import * as roles from "../utils/roles"; | ||
| import { Selector } from "testcafe"; | ||
| import * as functions from "../utils/functions"; | ||
| import { namedTestBucketBrowseButtonFor } from "../utils/functions"; | ||
|
|
||
| fixture("Test error visibility in Object Browser Navigation").page( | ||
| "http://localhost:9090/", | ||
| ); | ||
|
|
||
| const bucketName = "my-company"; | ||
| const bucketName2 = "my-company2"; | ||
| const bucketBrowseButton = namedTestBucketBrowseButtonFor(bucketName); | ||
| const bucketBrowseButton2 = namedTestBucketBrowseButtonFor(bucketName2); | ||
| export const file = Selector(".ReactVirtualized__Table__rowColumn").withText( | ||
| "test.txt", | ||
| ); | ||
| export const deniedError = Selector(".message-text").withText("Access Denied."); | ||
|
|
||
| test | ||
| .before(async (t) => { | ||
| await functions.setUpNamedBucket(t, bucketName); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName, | ||
| "test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName, | ||
| "home/UserY/test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName, | ||
| "home/UserX/test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| })( | ||
| "Error Notification is shown in Object Browser when no privileges are set", | ||
| async (t) => { | ||
| await t | ||
| .useRole(roles.conditions3) | ||
| .navigateTo(`http://localhost:9090/browser`) | ||
| .click(bucketBrowseButton) | ||
| .click(Selector(".ReactVirtualized__Table__rowColumn").withText("home")) | ||
| .click( | ||
| Selector(".ReactVirtualized__Table__rowColumn").withText("UserX"), | ||
| ) | ||
| .expect(deniedError.exists) | ||
| .ok(); | ||
| }, | ||
| ) | ||
| .after(async (t) => { | ||
| await functions.cleanUpNamedBucketAndUploads(t, bucketName); | ||
| }); | ||
|
|
||
| test | ||
| .before(async (t) => { | ||
| await functions.setUpNamedBucket(t, bucketName2); | ||
| await functions.setVersionedBucket(t, bucketName2); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName2, | ||
| "test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName2, | ||
| "home/UserY/test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| await functions.uploadNamedObjectToBucket( | ||
| t, | ||
| bucketName2, | ||
| "home/UserX/test.txt", | ||
| "portal-ui/tests/uploads/test.txt", | ||
| ); | ||
| })( | ||
| "Error Notification is shown in Object Browser with Rewind request set", | ||
| async (t) => { | ||
| await t | ||
| .useRole(roles.conditions4) | ||
| .navigateTo(`http://localhost:9090/browser`) | ||
| .click(bucketBrowseButton2) | ||
| .click(Selector("label").withText("Show deleted objects")) | ||
| .wait(1500) | ||
| .click(Selector(".ReactVirtualized__Table__rowColumn").withText("home")) | ||
| .click( | ||
| Selector(".ReactVirtualized__Table__rowColumn").withText("UserX"), | ||
| ) | ||
| .expect(deniedError.exists) | ||
| .ok(); | ||
| }, | ||
| ) | ||
| .after(async (t) => { | ||
| await functions.cleanUpNamedBucketAndUploads(t, bucketName2); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| { | ||
| "Version": "2012-10-17", | ||
| "Statement": [ | ||
| { | ||
| "Sid": "AllowUserToSeeBucketListInTheConsole", | ||
| "Action": [ | ||
| "s3:ListAllMyBuckets", | ||
| "s3:GetBucketLocation", | ||
| "s3:GetBucketVersioning" | ||
| ], | ||
| "Effect": "Allow", | ||
| "Resource": ["arn:aws:s3:::*"] | ||
| }, | ||
| { | ||
| "Sid": "AllowRootAndHomeListingOfCompanyBucket", | ||
| "Action": ["s3:ListBucket", "s3:List*"], | ||
| "Effect": "Allow", | ||
| "Resource": ["arn:aws:s3:::my-company2"], | ||
| "Condition": { | ||
| "StringEquals": { | ||
| "s3:prefix": ["", "home/", "home/User"], | ||
| "s3:delimiter": ["/"] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "Sid": "AllowListingOfUserFolder", | ||
| "Action": ["s3:ListBucket", "s3:List*"], | ||
| "Effect": "Allow", | ||
| "Resource": ["arn:aws:s3:::my-company2"], | ||
| "Condition": { | ||
| "StringLike": { | ||
| "s3:prefix": ["home/User/*"] | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "Sid": "AllowAllS3ActionsInUserFolder", | ||
| "Effect": "Allow", | ||
| "Action": ["s3:*"], | ||
| "Resource": ["arn:aws:s3:::my-company2/home/User/*"] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.