Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Sep 30, 2023

fixes #3001

What does this do?

Simplified the Object Browser code by changing the location of Websockets to be a middleware as well as simplifying the logic to handle the object browser paths

  • Refactored navigation to be handled only with URL
  • Refactored & simplified websocket
  • Updated components to use mds
  • Fixed an issue with Anonymous access and file selection
  • Fixed an issue with anonymous access and download selection click
  • Fixed an issue with object details selection on root path from a bucket
  • Simplified reducer

@jinapurapu
Copy link
Contributor

After creating a path, "Loading" remains, drag and drop upload doesn't work.

Screen.Recording.2023-10-02.at.11.09.53.AM.mov

@bexsoft bexsoft changed the title Object Browser Refactor [WIP] Object Browser Refactor Oct 2, 2023
@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label Oct 2, 2023
@bexsoft
Copy link
Collaborator Author

bexsoft commented Oct 2, 2023

After creating a path, "Loading" remains, drag and drop upload doesn't work.

Screen.Recording.2023-10-02.at.11.09.53.AM.mov

Fixed:
Screen Recording 2023-10-02 at 1 50 23 p m 2023-10-02 13_51_28

@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Oct 2, 2023
@bexsoft bexsoft changed the title [WIP] Object Browser Refactor Object Browser Refactor Oct 2, 2023
@jinapurapu
Copy link
Contributor

Clicking arrow icon to invert object list order causes "Loading" to hang:

Screen.Recording.2023-10-02.at.1.40.10.PM.mov

Copy link
Collaborator

@cesnietor cesnietor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested different scenarios with paths, tracing, anonymous buckets, deleting and adding multiple objects. All seems great.! Just left few comments.

@bexsoft bexsoft force-pushed the ob-refactor branch 2 times, most recently from 74284c7 to ac76bd7 Compare October 2, 2023 21:19
@bexsoft
Copy link
Collaborator Author

bexsoft commented Oct 2, 2023

Clicking arrow icon to invert object list order causes "Loading" to hang:

Screen.Recording.2023-10-02.at.1.40.10.PM.mov

Fixed

- Refactored navigation to be handled only with URL
- Refactored & simplified websocket
- Updated components to use mds
- Fixed an issue with Anonymous access and file selection
- Fixed an issue with anonymous access and download selection click
- Fixed an issue with object details selection on root path from a bucket
- Simplified reducer

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
@bexsoft bexsoft merged commit 083314e into minio:master Oct 2, 2023
@bexsoft bexsoft deleted the ob-refactor branch October 2, 2023 23:02
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Refactored navigation to be handled only with URL
- Refactored & simplified websocket
- Updated components to use mds
- Fixed an issue with Anonymous access and file selection
- Fixed an issue with anonymous access and download selection click
- Fixed an issue with object details selection on root path from a bucket
- Simplified reducer

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
- Refactored navigation to be handled only with URL
- Refactored & simplified websocket
- Updated components to use mds
- Fixed an issue with Anonymous access and file selection
- Fixed an issue with anonymous access and download selection click
- Fixed an issue with object details selection on root path from a bucket
- Simplified reducer

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bucket shows empty when a new object is uploaded

3 participants