fix: handle crash in error handling of access keys page #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsvmx
requested review from
bexsoft,
cesnietor,
cniackz,
dvaldivia,
jinapurapu,
kaankabalak and
reivaj05
harshavardhana
previously approved these changes
Sep 19, 2023
kaankabalak
previously approved these changes
Sep 19, 2023
kaankabalak
reviewed
Sep 19, 2023
kaankabalak
reviewed
Sep 19, 2023
portal-ui/src/screens/Console/Account/AddServiceAccountScreen.tsx
Outdated
Show resolved
Hide resolved
prakashsvmx
dismissed stale reviews from kaankabalak and harshavardhana
via
e8e2b10
prakashsvmx
force-pushed
the
handle-error-sa
branch
from
2cab1a5 to
e8e2b10
Compare
kaankabalak
approved these changes
Sep 19, 2023
harshavardhana
approved these changes
Sep 19, 2023
|
Some tests are failing @prakashsvmx |
cesnietor
approved these changes
Sep 19, 2023
bexsoft
approved these changes
Sep 19, 2023
|
Workflow errors seems not be related to this PR. Need to investigate |
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current response handler in UI crashes on any error from the back end.
This can be replicated easily by configuring LDAP and trying to create "Access Key" or simulating an error scenario from backend.
Replicate this in dev
Fix:
