Load the available CA in logout API #3044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
previously approved these changes
Sep 12, 2023
harshavardhana
requested changes
Sep 12, 2023
harshavardhana
requested changes
Sep 12, 2023
pjuarezd
force-pushed
the
bugfix-load-ca-logout
branch
from
182cb60 to
2c55345
Compare
pjuarezd
commented
Sep 12, 2023
harshavardhana
approved these changes
Sep 13, 2023
reivaj05
approved these changes
Sep 13, 2023
pjuarezd
force-pushed
the
bugfix-load-ca-logout
branch
from
2c55345 to
1e553a3
Compare
…gout` remote IDP endpoint. Out error log to stdout instead of return error to web client
pjuarezd
force-pushed
the
bugfix-load-ca-logout
branch
from
1e553a3 to
c01a283
Compare
harshavardhana
approved these changes
Sep 13, 2023
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
cesnietor
pushed a commit
to cesnietor/console
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Load the available CA in the API when invoking the
openid-connect/logoutremote IDP endpoint.Found that even though the CA certificates are properly provided to minio console, the invoke to the logout endpoint when using OIDP was not loading the CA certificates, causing several things:
API
/api/v1/logoutreturned a 500 error.API call returned
tls: failed to verify certificate: x509: certificate signed by unknown authorityerror:{ "detailedMessage": "Post \"https://kc-service.keycloak.svc.cluster.local/realms/oidc-iam/protocol/openid-connect/logout\": tls: failed to verify certificate: x509: certificate signed by unknown authority", "message": "an error occurred, please try again" }User session on IDP was not closed
User session in Minio Console was not really closed, user is still logged in