Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Sep 12, 2023

What does this do?

Added CONSOLE_PROMETHEUS_AUTH_TOKEN flag support for setups where prometheus has Bearer token authentication enabled.

NOTE: This PR doesn't support Basic Authentication method described in Prometheus website

reivaj05
reivaj05 previously approved these changes Sep 12, 2023
cesnietor
cesnietor previously approved these changes Sep 12, 2023
@bexsoft bexsoft dismissed stale reviews from cesnietor and reivaj05 via 5540b38 September 12, 2023 03:38
@bexsoft bexsoft changed the title Added CONSOLE_PROMETHEUS_BEARER flag support Added CONSOLE_PROMETHEUS_AUTH_TOKEN flag support Sep 12, 2023
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Copy link
Contributor

@kaankabalak kaankabalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 8a91832 into minio:master Sep 13, 2023
@bexsoft bexsoft deleted the prometheus-bearer branch September 13, 2023 18:02
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
cesnietor pushed a commit to cesnietor/console that referenced this pull request Jan 12, 2024
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants