-
Notifications
You must be signed in to change notification settings - Fork 495
Fixed an issue while deleting objects with similar prefixes #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could also avoid doing Listing() if an "object" has been selected to delete, not sure why we are listing even in this case. Listing is only needed if you are doing a directory delete. Can you explain why do we need to list() to DELETE ? |
We are using this function to list all the versions of an object and delete them |
So when all versions are not selected - are we not doing list() ? |
|
And what about unversioned bucket, where user selects do invoke delete all versions do we worry about listing at all ? Because there is no need to list since there is only one version. |
|
@bexsoft I have set up a data like below: Note: Nothing in Server Logs: Trace |
That's correct we have a separated clause for this case, we just list in case we want to delete multiple versions of an object. This is also the behavior we observed in mc |
Let me try to replicate this, one question when you are referring to Thank you in advance |
|
I was trying to delete prefix @bexsoft |
ff97523 to
d87b75a
Compare
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
d87b75a to
fc7ad9d
Compare
I reproduced the issue and sent a fix for it. Can you please help me to test again @prakashsvmx ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
What does this do?
Fixed an issue while deleting all versions, where if there were two files with similar prefixes but you only wanted to delete one, both files got deleted
How does it look?
Before
After