-
Notifications
You must be signed in to change notification settings - Fork 495
To properly show error in AddAccessRule.tsx #3008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1a9d586 to
cecc246
Compare
portal-ui/src/screens/Console/Buckets/BucketDetails/AddAccessRule.tsx
Outdated
Show resolved
Hide resolved
cecc246 to
9b7ba62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cniackz I think that similar to what you needed to do for setAccessRuleWithBucket request, the others responses should not be casted. Same comment from here #3008 (comment) applies.
You can test this by triggering an error on the response if possible.
portal-ui/src/screens/Console/Buckets/BucketDetails/AccessDetailsPanel.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/BucketDetails/AccessDetailsPanel.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/BucketDetails/AccessRulePanel.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/AddBucket.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx
Outdated
Show resolved
Hide resolved
1fbc0dd to
4c03052
Compare
|
What I believe we needed to do for this issue is just to make sure we do the dispatch of the snackbar message which catching the error. |
735ed5e to
0b80d25
Compare
|
@cniackz Checking the way you did the find (thanks for adding it to the description), we'd need to do something different cause the issue is that the errors are not being shown, meaning there is no dispatch so try doing a search on |
9344054 to
4102e03
Compare
|
Let's fix and test one by one to get it right. |
4102e03 to
5627f62
Compare
Objective:
To properly show error in
AddAccessRule.tsxAdditional Info:
How and where to test:
Administrator > Buckets > Anonymous > Add Access Rule > Save
How it should looks: