Migrated Buckets Pages to mds #2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
allanrogerr,
cesnietor,
cniackz,
dilverse,
dvaldivia,
jinapurapu,
kaankabalak,
prakashsvmx and
reivaj05
bexsoft
force-pushed
the
buckets-migration
branch
2 times, most recently
from
c247260 to
a388ed5
Compare
dvaldivia
previously approved these changes
Jul 25, 2023
|
Changes look good to me 👍 Some Observations: Adding bucket tag and removing does not reflect if there is only one tag. ( after deleting, page reload is required. "Refresh" also does not reflect) When creating a bucket with Object Locking and setting retention, the toggle could have green color as it is on. the current disabled state is makes it unclear
|
bexsoft
force-pushed
the
buckets-migration
branch
from
58bc45e to
4ecbe76
Compare
Migrated the Buckets page to the available mds compnents Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
bexsoft
force-pushed
the
buckets-migration
branch
from
745a2a5 to
5d19552
Compare
Addressed comments |
dvaldivia
approved these changes
Jul 28, 2023
oscarocastellanos
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
How does it look?