Skip to content

fix configuration page to include configs based on supported config subsystems #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2023
Merged

fix configuration page to include configs based on supported config subsystems #2946

merged 5 commits into from
Jul 20, 2023

Conversation

@prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Jul 17, 2023 •
edited
Loading

Fixes #2945

Test in Single drive mode ( Heal option is not available)
and Erasure/Distributed mode. ( Heal option is present)

@prakashsvmx prakashsvmx self-assigned this Jul 17, 2023
harshavardhana
harshavardhana reviewed Jul 17, 2023
View reviewed changes
@prakashsvmx prakashsvmx force-pushed the fix-heal-error-1-node branch from 1099407 to 639e916 Compare July 18, 2023 04:21
@prakashsvmx
Copy link
Member Author

prakashsvmx commented Jul 18, 2023

Thank you @harshavardhana 👍 . I have addressed the review comments.

harshavardhana
harshavardhana previously approved these changes Jul 18, 2023
View reviewed changes
@harshavardhana
Copy link
Member

harshavardhana commented Jul 18, 2023 

[4/4] Building fresh packages...
success Saved lockfile.
Done in 13.70s.
yarn run v1.22.19
$ /home/runner/work/console/console/portal-ui/node_modules/.bin/prettier --check .
Checking formatting...
[warn] src/screens/Console/Configurations/ConfigurationPanels/ConfigurationOptions.tsx
[warn] Code style issues found in the above file. Run Prettier to fix.
error Command failed with exit code 1.

bexsoft
bexsoft reviewed Jul 18, 2023
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update prettier to v3 & run make pretty under portal-ui, Thank you!

@prakashsvmx prakashsvmx force-pushed the fix-heal-error-1-node branch from 9be2763 to b441174 Compare July 19, 2023 02:30
@harshavardhana harshavardhana requested a review from bexsoft July 20, 2023 20:17
bexsoft
bexsoft approved these changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Detected an issue with override env variables not related to this PR. Will Fix accordingly in an upcoming PR

@bexsoft bexsoft merged commit 0823f62 into minio:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@bexsoft bexsoft bexsoft approved these changes

@cniackz cniackz Awaiting requested review from cniackz

@reivaj05 reivaj05 Awaiting requested review from reivaj05

@cesnietor cesnietor Awaiting requested review from cesnietor

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@prakashsvmx prakashsvmx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unknown subsystem: heal

3 participants

@prakashsvmx @harshavardhana @bexsoft